-
Couldn't load subscription status.
- Fork 105
Update composer command to run phpstan #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdates composer.json’s phpstan script to include a memory limit flag, changing from "./vendor/bin/phpstan" to "./vendor/bin/phpstan --memory-limit=512M". Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
40a20da to
69a080f
Compare
|
What's the point of this? |
|
I often run into memory issues when running This PR addresses the same memory limit issue fixed in #778. That other PR only focused on the Docker compose environment, though. I can circumvent it by running What do you think? |
|
But that depends on the environment. If i have much memory, why it should limit and run slower? 🙂 in #778 it was increased, so not the same |
|
Thanks for the clarification! Indeed, everyone should configure it manually if needed |
Pull Request
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit